This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Additional transaction tests #6509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
commented
Dec 19, 2018
| @@ -25,7 +25,7 @@ const flat_set<public_key_type>& transaction_metadata::recover_keys( const chain | |||
|
|
|||
| void transaction_metadata::create_signing_keys_future( const transaction_metadata_ptr& mtrx, | |||
| boost::asio::thread_pool& thread_pool, const chain_id_type& chain_id, fc::microseconds time_limit ) { | |||
| if( mtrx->signing_keys.valid() ) // already created | |||
| if( mtrx->signing_keys_future.valid() || mtrx->signing_keys.valid() ) // already created | |||
| return; | |||
There was a problem hiding this comment.
I do not believe create_signing_keys_future is called more than once, but add a check so that if it is called again before the future completes, it will not kick off another one.
brianjohnson5972
approved these changes
Dec 31, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Additional packed_transaction and transaction_metadata tests.
Consensus Changes
None.
API Changes
None
Documentation Additions
None