Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Set minimum dependencies for Debian packages. #6633

Merged
merged 3 commits into from
Jan 29, 2019

Conversation

jgiszczak
Copy link
Contributor

Change Description

Set minimum dependencies for Debian packages. Also ensure Debian subdirectory has correct permissions regardless of umask while packaging. Resolves #6618.

Consensus Changes

N/A

API Changes

N/A

Documentation Additions

N/A

@spoonincode
Copy link
Contributor

Would it be a better approach to derive the value from something like
ldd nodeos | grep libssl.so.1.1
So we didn't have to baby the script on new releases? Hard to say... new releases may do something wildly different anyways. I think I'm mostly indifferent, at least this gets us the correct values for the two versions we support.

@jgiszczak
Copy link
Contributor Author

I used

$ ldd ./nodeos | awk '/=>/{print $(NF-1)}' | while read n; do dpkg-query -S $n; done | sed 's/^\([^:]\+\):.*$/\1/' | sort | uniq

(and again for keosd and cleos) to compose the dependency list and even that results in a spurious error from dpkg-query, as the '=>' from ldd isn't successfully filtered out. That mess comes very close, but I hesitate to call it robust enough to use it as a fire and forget package builder. That's what debhelper is for.

Also ensure Debian subdirectory has correct permissions regardless of
umask while packaging.
@jgiszczak jgiszczak force-pushed the revise-deb-package-dependencies branch from 2773c1b to 3c1dffc Compare January 26, 2019 00:35
scripts/generate_deb.sh Outdated Show resolved Hide resolved
@spoonincode spoonincode merged commit 4e9e327 into develop Jan 29, 2019
@jgiszczak jgiszczak deleted the revise-deb-package-dependencies branch January 29, 2019 20:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants