This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r testing to be sure tests pass on mac
spoonincode
suggested changes
Feb 14, 2019
…d, it will skip trying to install the plugin + a bit of cleanup
spoonincode
approved these changes
Feb 15, 2019
NorseGaud
force-pushed
the
v2-build-scripts-for-ci
branch
from
February 15, 2019 21:52
f2ec7a1
to
48da685
Compare
larryk85
approved these changes
Feb 15, 2019
spoonincode
suggested changes
Feb 17, 2019
spoonincode
approved these changes
Feb 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates since review:
Build Script changes:
CMakeModules changes:
Test changes
Notes:
VM Image Speed Improvements: