This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e methods of counting cores in Buildkite containers
spoonincode
suggested changes
Feb 10, 2019
spoonincode
reviewed
Feb 10, 2019
…from CMakeLists.txt
…s tests, confirmed with Areg and Bucky
zreyn
previously approved these changes
Feb 11, 2019
spoonincode
previously approved these changes
Feb 11, 2019
zreyn
approved these changes
Feb 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
unit_test_wavm was our longest-running, non-LRT test at 228 seconds. unit_test_wavm is a set of test suites and, to enable these individual suites to be run in parallel, has been broken down by test suite now. unit_test_wabt is actually the same set of test cases called with one different command-line parameter, so that has been parallelized as well. These tests now run over twice as fast in buildkite and almost six times faster on my local machine.
Consensus Changes
None.
API Changes
None.
Documentation Additions
None?