Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

protocol upgrade activation mechanism (also implements PREACTIVATE_FEATURE and ONLY_LINK_TO_EXISTING_PERMISSION protocol features) #6831

Merged
merged 83 commits into from
Mar 26, 2019
Merged

protocol upgrade activation mechanism (also implements PREACTIVATE_FEATURE and ONLY_LINK_TO_EXISTING_PERMISSION protocol features) #6831

merged 83 commits into from
Mar 26, 2019

Commits on Jan 30, 2019

  1. initial work on #6429

    @arhag
    arhag committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    5799292 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2019

  1. more work on #6429

    @arhag
    arhag committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    1d2e24b View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2019

  1. some fixes for #6429

    @arhag
    arhag committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    19e7720 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2019

  1. Merge branch 'protocol-feature-foundations' into 6429-protocol-upgrad… 

    …e-activation-mechanism
    @arhag
    arhag committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    0784a75 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2019

  1. update protocol-feature structs to use new fc::reflector_init; loggin… 

    …g for recognized protocol features #6429
    @arhag
    arhag committed Feb 23, 2019
    Configuration menu
    Copy the full SHA
    08318b7 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2019

  1. enum hash function needs to be explicit to work with old gcc compiler… 

    … of Ubuntu 16.04 #6429
    @arhag
    arhag committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    1fd25de View commit details
    Browse the repository at this point in the history

  2. use nth_element rather than sort in calc_dpos_last_irreversible

    @arhag
    arhag committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    9940b2c View commit details
    Browse the repository at this point in the history

  3. switch protocol_feature_activation_handlers to unordered_map #6429

    @arhag
    arhag committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    cee12cc View commit details
    Browse the repository at this point in the history

  4. basic support for preactivation #6429 #6431

    @arhag
    arhag committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    a72eda9 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2019

  1. initial work on #6437

    @arhag
    arhag committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    2d4d0d3 View commit details
    Browse the repository at this point in the history

  2. bug fixes and improvements #6437

    @arhag
    arhag committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    feb6456 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2019

  1. fix pending_schedule_hash

    @taokayan
    taokayan committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    2aeb626 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #6865 from taokayan/6429-fix-kayan 

    fix pending_schedule_hash
    @arhag
    arhag authored Mar 5, 2019
    Configuration menu
    Copy the full SHA
    9d14248 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2019

  1. Merge branch 'protocol-feature-foundations' into 6429-protocol-upgrad… 

    …e-activation-mechanism
    @arhag
    arhag committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    3e9a2c8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'protocol-feature-foundations' into 6429-protocol-upgrad… 

    …e-activation-mechanism
    @arhag
    arhag committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    2ce825f View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2019

  1. add dependencies to hash that generates feature digest

    @arhag
    arhag committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    97f57de View commit details
    Browse the repository at this point in the history

  2. remove digest from protocol feature JSON filenames since they can bec… 

    …ome inconsistent with the contents
    @arhag
    arhag committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    1459875 View commit details
    Browse the repository at this point in the history

  3. set description digest for PREACTIVATE_FEATURE

    @arhag
    arhag committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    8c915c9 View commit details
    Browse the repository at this point in the history

  4. fix bug in protocol_feature_manager::add_feature leading to undefined… 

    … behavior
    @arhag
    arhag committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    6e3c7cb View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2019

  1. Merge branch '6437-intrinsics' into 6429-protocol-upgrade-activation-… 

    …mechanism
    @arhag
    arhag committed Mar 9, 2019
    Configuration menu
    Copy the full SHA
    bfead42 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'protocol-feature-foundations' into 6429-protocol-upgrad… 

    …e-activation-mechanism
    @arhag
    arhag committed Mar 9, 2019
    Configuration menu
    Copy the full SHA
    71c4187 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'protocol-feature-foundations' into 6429-protocol-upgrad… 

    …e-activation-mechanism
    @arhag
    arhag committed Mar 9, 2019
    Configuration menu
    Copy the full SHA
    66ef224 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2019

  1. add preactivate_feature and is_feature_activated intrinsics; add get_… 

    …scheduled_protocol_feature_activations and schedule_protocol_feature_activations to producer_api_plugin
    @arhag
    arhag committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    1dd9a35 View commit details
    Browse the repository at this point in the history

  2. fix bug in pending_block_header_state::_finish_next which created an … 

    …inconsistent header_exts
    @arhag
    arhag committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    df1379e View commit details
    Browse the repository at this point in the history

  3. add intrinsics on PREACTIVATE_FEATURE activation

    @arhag
    arhag committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    c64c963 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2019

  1. add protocol_feature_tests/activate_preactivate_feature unit test

    @arhag
    arhag committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    9deb6f7 View commit details
    Browse the repository at this point in the history

  2. Initial modification to tester for pfm without modifying current test… 

    … behaviour
    Andrianto Lie committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    9340e2c View commit details
    Browse the repository at this point in the history

  3. Change default setup_policy to full and fixes the existing test

    Andrianto Lie committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    2398d8c View commit details
    Browse the repository at this point in the history

  4. rename schedule_all_builtin_protocol_features to preactivate_all_buil… 

    …tin_protocol_feature and reimplement to respect dependencies and earliest allow activation time
    @arhag
    arhag committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    8fb0d29 View commit details
    Browse the repository at this point in the history

  5. for now switch back to using old bios contract in smoke tests until t… 

    …hey are updated to initially activate PREACTIVATE_FEATURE
    @arhag
    arhag committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    6bd09b1 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #6917 from EOSIO/6429-test 

    Modify the tester to activate builtin protocol features during init
    @arhag
    arhag authored Mar 12, 2019
    Configuration menu
    Copy the full SHA
    6ec6afd View commit details
    Browse the repository at this point in the history

  7. avoid redundant validate_and_extract_header_extensions in fork_databa… 

    …se::add
    @arhag
    arhag committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    5c36f61 View commit details
    Browse the repository at this point in the history

  8. check for invalid protocol feature activations earlier when producing… 

    … a block
    @arhag
    arhag committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    9ad228b View commit details
    Browse the repository at this point in the history

  9. correct action name for preactivate_protocol_features

    @arhag
    arhag committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    0b00d78 View commit details
    Browse the repository at this point in the history

  10. add dependency checking to controller::preactivate_feature

    @arhag
    arhag committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    625fce6 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2019

  1. bug fix in start_block: improper count to check if all preactivated f… 

    …eatures were activated
    @arhag
    arhag committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    3628676 View commit details
    Browse the repository at this point in the history

  2. add get_supported_protocol_features to producer_api_plugin

    @arhag
    arhag committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    a4bde90 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2019

  1. Fix reversed condition in get supported protocol API

    Andrianto Lie committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    caaa5c9 View commit details
    Browse the repository at this point in the history

  2. fix a case if started block get aborted

    @taokayan
    taokayan committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    488b8e6 View commit details
    Browse the repository at this point in the history

  3. fix duplication check bug in controller_impl::start_block

    @arhag
    arhag committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    421bc24 View commit details
    Browse the repository at this point in the history

  4. add ONLY_LINK_TO_EXISTING_PERMISSON protocol feature (enables writing… 

    … unit tests that test preactivation); bug fixes in validating_tester
    @arhag
    arhag committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    1b5cece View commit details
    Browse the repository at this point in the history

  5. add additional unit tests for protocol activation; fix bug that lead … 

    …to inconsistent state due to controller_impl::start_block exception
    @arhag
    arhag committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    a7158b1 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #6935 from taokayan/6429-producerfix-kayan 

    fix a case if started block get aborted
    @arhag
    arhag authored Mar 14, 2019
    Configuration menu
    Copy the full SHA
    1cdf8ed View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2019

  1. Add capability to activate preactivate feature in the python testing … 

    …framework
    Andrianto Lie committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    d9fe459 View commit details
    Browse the repository at this point in the history

  2. decode binary RPC response in sendRpcApi before converting to JSON

    @arhag
    arhag authored and Andrianto Lie committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    a9d9152 View commit details
    Browse the repository at this point in the history

  3. Use API to get feature digest for preactivate protocol feature

    Andrianto Lie committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    e7440bb View commit details
    Browse the repository at this point in the history

  4. Change python cluster to use setup policy enum

    Andrianto Lie committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    2383606 View commit details
    Browse the repository at this point in the history

  5. remove dependency on enum.auto (not available to all platforms)

    @arhag
    arhag authored and Andrianto Lie committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    5b77b49 View commit details
    Browse the repository at this point in the history

  6. Preactivate feature inside bios_boot.sh created by launcher

    Andrianto Lie committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    424374d View commit details
    Browse the repository at this point in the history

  7. fix single producer node case for preactivation

    @taokayan
    taokayan committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    2211e9a View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2019

  1. Redesign protocol_feature_manager to fix bug which would lead to inco… 

    …nsistent state with respect to activations after a restart.

Add get_activated_protocol_features to chain_api_plugin. Redesign of 
protocol_feature_manager also supports the implementation of this RPC.
    @arhag
    arhag committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    355f143 View commit details
    Browse the repository at this point in the history

  2. add protocol_feature_tests/activate_and_restart unit test

    @arhag
    arhag committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    f23069d View commit details
    Browse the repository at this point in the history

  3. port over @taokayan's producer_plugin fixes from #6949

    @arhag
    arhag committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    a15322a View commit details
    Browse the repository at this point in the history

  4. Merge branch '6429-protocol-upgrade-activation-mechanism' into 6429-p… 

    …ython-test
    @arhag
    arhag committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    ab24a3f View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2019

  1. fix python tests

    @taokayan
    taokayan committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    0d564cf View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2019

  1. fix bug in block_header_state::next regarding producer_to_last_produc… 

    …ed; add unit test producer_schedule_tests/producer_watermark_test
    @arhag
    arhag committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    a903640 View commit details
    Browse the repository at this point in the history

  2. Add some helper functions for Cluster and Node

    Andrianto Lie committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    21ec01f View commit details
    Browse the repository at this point in the history

  3. Remove dependency on enum module

    Andrianto Lie committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    d85b415 View commit details
    Browse the repository at this point in the history

  4. Remove wrong type checking

    Andrianto Lie committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    2a93b33 View commit details
    Browse the repository at this point in the history

  5. fix python test that failed in some servers

    @taokayan
    taokayan committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    43d8eb9 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #6924 from EOSIO/6429-python-test 

    Add capability to activate PREACTIVATE_FEATURE in the python testing framework
    @arhag
    arhag authored Mar 19, 2019
    Configuration menu
    Copy the full SHA
    a1b7b56 View commit details
    Browse the repository at this point in the history

  7. Merge pull request #6949 from taokayan/6429-producerfix-kayan 

    fix single producer node case for preactivation & add python test
    @arhag
    arhag authored Mar 19, 2019
    Configuration menu
    Copy the full SHA
    e1e776f View commit details
    Browse the repository at this point in the history

  8. Set PFSetupPolicy to be NONE for prod preactivate test

    Andrianto Lie committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    dfe276b View commit details
    Browse the repository at this point in the history

  9. Merge pull request #6965 from EOSIO/6429-fix-after-merge 

    Set PFSetupPolicy to be NONE for prod preactivate test
    @taokayan
    taokayan authored Mar 19, 2019
    Configuration menu
    Copy the full SHA
    53d77f4 View commit details
    Browse the repository at this point in the history

  10. enforce preactivation_required in controller_impl::start_block; add u… 

    …nit test protocol_feature_tests/require_preactivation_test to verify this
    @arhag
    arhag committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    ad8da6b View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2019

  1. protocol_feature_set::make_default_builtin_protocol_feature can be st… 

    …atic
    @arhag
    arhag committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    568476a View commit details
    Browse the repository at this point in the history

  2. Add subjective restriction procotol feature test

    Andrianto Lie committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    c4631a5 View commit details
    Browse the repository at this point in the history

  3. Add test to CMakeList.txt

    Andrianto Lie committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    a6bed12 View commit details
    Browse the repository at this point in the history

  4. nodeos_protocol_feature_test now only tests JSON read feature

    Andrianto Lie committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    ec1e2f1 View commit details
    Browse the repository at this point in the history

  5. Label nodeos_protocol_feature_test as nonparallelizable_tests

    Andrianto Lie committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    a54dd46 View commit details
    Browse the repository at this point in the history

  6. prevent producer plugin from scheduling a feature that require preact… 

    …ivation
    @taokayan
    taokayan committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    ff870f5 View commit details
    Browse the repository at this point in the history

  7. Add unit test to test subject restrictions

    Andrianto Lie committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    ccb1a8c View commit details
    Browse the repository at this point in the history

  8. Add more coverage on the test case

    Andrianto Lie committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    765d831 View commit details
    Browse the repository at this point in the history

  9. Change permission of nodeos_protocol_feature_test to executable

    Andrianto Lie committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    de1565e View commit details
    Browse the repository at this point in the history

  10. Merge pull request #6972 from taokayan/6429-producerfix2-kayan 

    prevent producer plugin from scheduling a feature that require preactivation
    @arhag
    arhag authored Mar 20, 2019
    Configuration menu
    Copy the full SHA
    a860f9f View commit details
    Browse the repository at this point in the history

  11. pass custom_subjective_restrictions by reference into make_protocol_f… 

    …eature_set of tester
    @arhag
    arhag committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    dde3b35 View commit details
    Browse the repository at this point in the history

  12. some cleanup in protocol_feature_tests/subjective_restrictions_test

    @arhag
    arhag committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    d89e525 View commit details
    Browse the repository at this point in the history

  13. Merge pull request #6964 from EOSIO/6429-subj-protocol-python-test 

    Add subjective restriction procotol feature test
    @arhag
    arhag authored Mar 20, 2019
    Configuration menu
    Copy the full SHA
    57c2f53 View commit details
    Browse the repository at this point in the history

  14. allow is_feature_activated to be called by unprivileged contracts

    @arhag
    arhag committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    6dfb043 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2019

  1. fix bios_boot script for feature_digest param

    @taokayan
    taokayan committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    79c2be8 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #6977 from taokayan/6429-scriptfix-kayan 

    fix bios_boot script for feature_digest param
    @arhag
    arhag authored Mar 21, 2019
    Configuration menu
    Copy the full SHA
    59bce76 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2019

  1. store whitelisted_intrinsics in portable snapshot as a set of intrins… 

    …ic names
    @arhag
    arhag committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    ab4a0ef View commit details
    Browse the repository at this point in the history

  2. remove wlogs from get_activated_protocol_features

    @arhag
    arhag committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    a8cd499 View commit details
    Browse the repository at this point in the history