This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
fix bug in apply_block that constructed and committed blocks with missing signatures in the protocol-feature-foundations branch #6856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a missing signature in the block #6851 Also adds unit test to check for this case.
andriantolie
approved these changes
Mar 4, 2019
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Resolves #6851.
Fixes a bug in
apply_blockwhich constructed a completed block state with a missing signature in the block. The invalid block was then committed into the reversible block database. Also theblock_statecontaining the invalid block was emitted with theaccepted_blocksignal which thenet_pluginuses to broadcast the (invalid) block, leading to issues like the one described in #6851.This PR also adds a unit test to check for this case.
Consensus Changes
API Changes
Documentation Additions