This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Implement NO_DUPLICATE_DEFERRED_ID protocol feature #7072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the `num_failed` tracker and blacklist of producer_plugin to work as intended. Preserves the current pattern of not retiring (except for case with expired status) deferred transaction with invalid extensions even after NO_DUPLICATE_DEFERRED_ID activation.
…of iterating through the provided list #6115
…efore calling bios_boot.sh #6115
… the getAllBuiltinFeatureDigestsToPreactivate function in Node.py #6115
…to test the NO_DUPLICATE_DEFERRED_ID protocol feature. #6115 Updated the deferred_test test contract to support testing requirements of new test.
taokayan
approved these changes
Apr 11, 2019
3 tasks
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Resolves #6115.
This PR adds support for the
NO_DUPLICATE_DEFERRED_IDprotocol feature which makes changes to ensure that it is virtually impossible for deferred transactions to end up with a transaction ID that collides with the ID of any other transaction that is scheduled/retired in the blockchain, and also makes it possible for a contract to know the transaction ID of the scheduled deferred transaction prior to sending it.This PR also makes changes to better handle the error case of a transaction containing disallowed extensions.
This PR introduces a new unit test protocol_feature_tests/no_duplicate_deferred_id_test to test the behavior of this new protocol feature. The deferred_test test contract was augmented to meet the needs of the new unit test.
Consensus Changes
Makes the
NO_DUPLICATE_DEFERRED_IDprotocol feature available. See above description and #6115 for details.The
NO_DUPLICATE_DEFERRED_IDprotocol feature depends on theREPLACE_DEFERREDprotocol feature (#6997). See this comment for details about what that means.API Changes
Documentation Additions