This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Remove dead code from fork_database #7101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove following dead code from fork_database - fork_database::add( const header_confirmation& c ) - fork_database::set_bft_irreversible( block_id_type id ) Closes EOSIO#7100 Signed-off-by: Hyung-Kyu Choi <hyungkyu.choi@gmail.com>
|
@arhag I assume you have already made these changes on your fork db refactor branch. |
|
Thanks @hqueue for your contribution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Remove following dead code from fork_database
fork_database::add( const header_confirmation& c )fork_database::set_bft_irreversible( block_id_type id )Above two member functions of
fork_datatbaseare not used anymore since PR #6149 which removedcontroller::push_confirmation.Closes #7100
Consensus Changes
API Changes
Documentation Additions