Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Implement RAM_RESTRICTIONS protocol feature #7131

Merged
merged 9 commits into from
Apr 18, 2019
Merged

Implement RAM_RESTRICTIONS protocol feature #7131

merged 9 commits into from
Apr 18, 2019

Conversation

arhag
Copy link
Contributor

@arhag arhag commented Apr 16, 2019 •
edited
Loading

Change Description

Resolves #6105.

This PR adds support for the RAM_RESTRICTIONS protocol feature which, when activated makes the following changes to the rules regarding RAM billing within an action:

  • For an unprivileged contract responding to a notification:

    • Not allowed to schedule a deferred transaction in which the RAM costs are paid by an account other than receiver.
    • Allowed to execute database operations that increase RAM usage of an arbitrary account other than receiver as long as the action's net effect on RAM usage for that account is to not increase it.

  • For an unprivileged contract executing an action (but not as a response to a notification):

    • Not allowed to schedule a deferred transaction in which the RAM costs are paid by an account other than receiver unless that account authorized the action.
    • Allowed to execute database operations that increase RAM usage of an arbitrary account other than receiver as long as either that account authorized the action or the action's net effect on RAM usage for that account is to not increase it.

This PR introduces a new unit test protocol_feature_tests/ram_restrictions_test to test the behavior of this new protocol feature. The ram_restrictions_test test contract was added to meet the needs of the new unit test.

Consensus Changes

  • Consensus Changes

Makes the RAM_RESTRICTIONS protocol feature available. See above description and #6105 for details.

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

arhag and others added 5 commits April 15, 2019 18:00
@arhag
implement RAM_RESTRICTIONS protocol feature #6105
d0746b6
@arhag
fix api_tests/ram_billing_in_notify_tests to not activate RAM_RESTRIC…
f9ab463 
…TIONS; fix api_tests/deferred_transaction_tests to catch the right exception given RAM_RESTRICTIONS activation #6105
@arhag
disable_all_subjective_mitigations now disables the subjective mitiga…
af75206 
…tion preventing RAM billing in notification contexts #6105
@taokayan
add test case
7812709
@taokayan
add test cases
f2debc2
@taokayan taokayan mentioned this pull request Apr 18, 2019
Merged
@arhag arhag marked this pull request as ready for review April 18, 2019 21:34
@arhag arhag requested a review from johndebord April 18, 2019 21:34
johndebord
johndebord approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@johndebord johndebord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@arhag arhag merged commit 5301a91 into forced-replay Apr 18, 2019
@arhag arhag deleted the 6105-ram-restrictions branch April 18, 2019 23:08
This was referenced Apr 18, 2019
Merged
Closed
Closed
@arhag arhag mentioned this pull request Jul 3, 2019
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johndebord johndebord johndebord approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arhag @johndebord @taokayan