This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Limit ubuntu versions eosio_build.sh runs on to 16.04 & 18.04 #7133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoonincode
force-pushed
the
limit_ubuntu_versions
branch
from
a31ef41
to
7517d70
Compare
larryk85
approved these changes
Apr 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
The script is known to not work on 18.10 (see #7066) and it's pretty clear it's not going to work on 19.04. Limit the ubuntu versions that the script runs as I don't anticipate anyone fixing it before 1.8
Consensus Changes
API Changes
Documentation Additions