This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
reduction of wavm memory usage #7171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generation of debug info consumes a massive amount of memory and quite a bit of it seems to get lodged in the global llvmcontext meaning it becomes a leak in the current design of wavm. Removing this as we don't need it
After creating a ModuleInstance from a Module, we really don't need to hold on to the Module any longer. It's a memory sink. Refactor the one instance we needed the Module and free it after that
heifner
suggested changes
Apr 22, 2019
this lookup should be well protected; but no complaints to protect it further it's not a hot path or anything
heifner
approved these changes
Apr 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
wavm tends to cause significant memory usage even when fixes like #6983 are in place. This PR includes two changes that reduce the memory usage of WAVM by a large margin. First: avoid generation of debug information; this was actually done at a per-wasm-opcode resolution so it was very memory intensive and also tended to wedge things in to a global cache that would never be freed. Second: free the WAVM Module after we no longer need it once a ModuleInstance is created from it
Consensus Changes
API Changes
Documentation Additions