This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
link to icu or sasl2 when appropriate for mongo #7227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mongo-c-driver could require linkage to libicu or libsasl2 depending on how it was configured when built. We can't just use MONGOC_STATIC_LIBRARIES variables from its cmake file because these static variants may try to static link against libraries we don't want (like a system libc/c++). But we need to know if mongo c driver was built with ICU or SASL2 support so hat we can continue to link to those. This certainly is a bit on the fragile side but try to parse what is included in MONGOC_STATIC_LIBRARIES to see what we should link to
arhag
approved these changes
Apr 26, 2019
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
mongo-c-driver could require linkage to libicu or libsasl2 depending on how it was configured when built. We can't just use MONGOC_STATIC_LIBRARIES variables from its cmake file because these static variants may try to static link against libraries we don't want (like a system libc/c++). But we need to know if mongo c driver was built with ICU or SASL2 support so hat we can continue to link to those. This certainly is a bit on the fragile side but try to parse what is included in MONGOC_STATIC_LIBRARIES to see what we should link to
Consensus Changes
API Changes
Documentation Additions