Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Http configurable logging #7249

Merged
merged 2 commits into from
May 2, 2019
Merged

Http configurable logging #7249

merged 2 commits into from
May 2, 2019

Conversation

heifner
Copy link
Contributor

@heifner heifner commented May 1, 2019

Change Description

  • Add configurable logging to http_plugin controlled by "http_plugin" log name.
  • A logging.json file will now need to be provided to get logging previously provided by default.
  • See example logging.json in ./programs/nodeos directory.

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • [ x ] Documentation Additions

  • Documentation portraying expected nodeos output may need to be adapted to match the new less verbose output. Either that or the documentation should describe adding a logging.json with debug settings.

@heifner heifner requested a review from jgiszczak May 2, 2019 14:08
@jgiszczak
Copy link
Contributor

Documentation portraying expected nodeos output may need to be adapted to match the new less verbose output. Either that or the documentation should describe adding a logging.json with debug settings.

@@ -73,6 +82,15 @@
"stderr",
"net"
]
},{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't part of another PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it was missed on the original addition of this example logging.json

Copy link
Contributor

@jgiszczak jgiszczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw everything I expected to see. I didn't expand all the unmodified rows to look for missed dlog/ilog/elogs. I'm assuming search and replace took care of them all.

@heifner heifner merged commit 1836876 into develop May 2, 2019
@heifner heifner deleted the http-logging branch May 2, 2019 18:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants