This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
simplify openssl setup in cmakelists #7278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Much of the openssl setup in the cmakelists is redundant or wrong. OPENSSL_INCLUDE_DIR is an output variable so we shouldn't be setting that. The openssl finding logic built in to cmake already looks at the OPENSSL_ROOT_DIR environment variable on its own so don't need to try to pass that. And on any unix it will already search for a pkgconfig file for openssl so don't really need to do anything on linux. We do still need to keep something here for macOS as for whatever reason homebrew doesn't link in openssl's pkgconfig file (maybe due to concern of conflict?)
larryk85
approved these changes
May 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Much of the openssl setup in the cmakelists is redundant or wrong. OPENSSL_INCLUDE_DIR is an output variable so we shouldn't be setting that. The openssl finding logic built in to cmake already looks at the OPENSSL_ROOT_DIR environment variable on its own so don't need to try to pass that. And on any unix it will already search for a pkgconfig file for openssl so don't really need to do anything on linux.
We do still need to keep something here for macOS as for whatever reason homebrew doesn't link in openssl's pkgconfig file (maybe due to concern of conflict?)
Consensus Changes
API Changes
Documentation Additions