This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
build unittests in c++17, not c++14 - 1.8 #7280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the CMAKE_CXX_STANDARD override here. Also I got a bit lucky because <boost/range/alogrithm.hpp> will not compile in c++17 mode due to the removal of std::random_shuffle. However, we didn't need that include anyways at the moment since a bunch of stuff in that file is #if 0ed
heifner
approved these changes
May 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Remove the CMAKE_CXX_STANDARD override here. Also I got a bit lucky because <boost/range/alogrithm.hpp> will not compile in c++17 mode due to the removal of std::random_shuffle. However, we didn't need that include anyways at the moment since a bunch of stuff in that file is #if 0ed
Consensus Changes
API Changes
Documentation Additions