This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
chainbase uniqueness violation fixes #7286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t violate the new (and now explicitly stated) requirements imposed on chainbase objects that should be respected in this code base. Following those new requirements will automatically satisfy the critical preconditions on the chainbase modify function. Add new unit test, api_tests/more_deferred_transaction_tests, to check that certain deferred transaction replacement schemes do not cause chainbase failure any more. Modified the deferred_test test contract to support the new unit test.
heifner
approved these changes
May 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Port #7266 to develop.
Consensus Changes
API Changes
Documentation Additions