This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
when unable to find mongo driver stop cmake #7306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the mongo plugin cmake would simply print a message that it couldn't find a mongo c driver and carry on. But this means compilation of nodeos will fail because BUILD_MONGO_DB_PLUGIN is still set to ON so nodeos cmake will try to link against the plugin that is not built. Can't just set BUILD_MONGO_DB_PLUGIN to OFF here because of cmake scoping rules Might as well just error out; I don't think many people will set this to ON and then want the build to plow ahead anyways
heifner
approved these changes
May 8, 2019
… that we error out
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Previously the mongo plugin cmake would simply print a message that it couldn't find a mongo c driver and carry on. But this means compilation of nodeos will fail because BUILD_MONGO_DB_PLUGIN is still set to ON so nodeos cmake will try to link against the plugin that is not built.
Can't just set BUILD_MONGO_DB_PLUGIN to OFF here because of cmake scoping rules
Might as well just error out; I don't think many people will set this to ON and then want the build to plow ahead anyways
Consensus Changes
API Changes
Documentation Additions