This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
fix block serialization order in fork_database::close - v1.8.x #7326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ong order (caused linking issues when opening the file) Also adds forked_tests/reopen_forkdb unit test.
heifner
approved these changes
May 11, 2019
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This PR fixes a bug in
fork_database::closewhich serialized blocks to disk in the wrong order thus causing unlinkable block errors when attempting to open the fork_db.dat file infork_database::open.Also, a new unit test,
forked_tests/reopen_forkdb, has been added to test a scenario that lead to the unlinkable block errors described above when thefork_database::closewas not fixed.Consensus Changes
API Changes
Documentation Additions