Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Add Version Check for Package Builder #7341

Merged
merged 41 commits into from
May 15, 2019
Merged

Add Version Check for Package Builder #7341

merged 41 commits into from
May 15, 2019

Conversation

kj4ezj
Copy link
Contributor

@kj4ezj kj4ezj commented May 13, 2019

Change Description

Last week, we had an issue where the binaries attached to a 1.8 release contained a 1.7 version string.

Version Label Integration Test

This pull request introduces the "version-label" integration test, which compares the output of nodes --version to our CMake files to determine that the version string is what we expect it to be. This test will only run in Buildkite against tagged builds. If this test is not running in Buildkite or the build does not have a GitHub tag, this test immediately returns EXIT_SUCCESS.

Package Builder Improvements

Because this check was initially going to be in the package builder step, I have also made changes there:

  • Moved commands into script
  • Step now fails if there are no packages produced
  • Prints commit hash of build directory being used
  • Detects host operating system and runs correct package builder instructions for you

Tested

See Also

Consensus Changes

  • Consensus Changes
    None.

API Changes

  • API Changes
    None.

Documentation Additions

  • Documentation Additions
    None.

@kj4ezj kj4ezj marked this pull request as ready for review May 14, 2019 18:16
@kj4ezj kj4ezj changed the title Add Version Check to Package Builder Add Version Check for Package Builder May 14, 2019
@kj4ezj kj4ezj merged commit 6eb8d1b into develop May 15, 2019
@kj4ezj kj4ezj deleted the zach-package-check branch May 15, 2019 20:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants