This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Allow aliases of variants in ABI #7377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves 7254 We had a redundant validation that attempted to prevent aliasing to an unknown type however, this was done before variants were loaded so, it would reject an alias of a variant. `::validate` will perform this validation after all types are known so, this assert was not needed
|
We may want to backport this to supported versions as it is preventing tooling based on those versions from accepting well-formed ABI's from CDT |
heifner
reviewed
May 17, 2019
…ception expectation on other unit test
heifner
approved these changes
May 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This resolves #7254
We had a redundant validation that attempted to prevent aliasing to an unknown type however, this was done before variants were loaded so, it would reject an alias of a variant.
::validatewill perform this validation after all types are known so, this assert was not neededConsensus Changes
API Changes
Documentation Additions