This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
set initial costs for expensive parallel unit tests #7451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running multiple tests in parallel it is most optimal to run the longest ones first. Add some initial costs to the known pigs so that they run first.
heifner
approved these changes
Jun 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
When running multiple tests in parallel it is most optimal to run the longest ones first. Add some initial costs to the known pigs so that they run first.
This improved performance of running the parallel tests via
-j8by ~15% for me.Astute users will notice that if they run ctest a second time the tests do not run in the same order as the first time. ctest actually records the costs for each test in Testing/Temporary/CTestCostData.txt so that subsequent runs are more optimal. This auto-cost generation doesn't help the CI builds since they are always fresh.
Consensus Changes
API Changes
Documentation Additions