This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fix abi_serializer to encode optional non-built_in types #7477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1bart
suggested changes
Jun 12, 2019
|
It's strange. In local build and unit_test execution, I didn't encounter any errors, but automated checks by buildkite seem to be failed. I don't have permission to look into buildkite results, can you tell me what the problem is? |
|
@conr2d Sorry for the confusion, these PRs fail because our build infrastructure cannot trust your fork of the repository. We are working to resolve this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Fixes #7450.
Current version of
_variant_to_binarydoesn't handle optional of non-built_in types.Consensus Changes
API Changes
Documentation Additions