Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix Incorrectly Resolved and Untested Merge Conflicts in Pipeline Configuration File #7489

Merged
merged 3 commits into from
Jun 11, 2019

Conversation

kj4ezj
Copy link
Contributor

@kj4ezj kj4ezj commented Jun 11, 2019

Change Description

I removed the auto-buildkite-pipelines:protocol-features-sync-nodes branch in pull request 7467 but then, in commit 2bcddd7fca4162f49db350ece8e27b49cd8e5080, someone incorrectly resolved merge conflicts and pointed the eosio-lrt and eosio-build-unpinned pipelines at this deleted branch without testing their changes.
I have restored these pipelines to their state in pull request 7467.

Tested

Consensus Changes

  • Consensus Changes
    None.

API Changes

  • API Changes
    None.

Documentation Additions

  • Documentation Additions
    None.

Copy link
Contributor

@zreyn zreyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kj4ezj kj4ezj merged commit 70b30af into develop Jun 11, 2019
@kj4ezj kj4ezj deleted the zach-pipeline-config branch June 11, 2019 18:06
@NorseGaud
Copy link
Contributor

How come LRT is using 1.8.0?

@kj4ezj
Copy link
Contributor Author

kj4ezj commented Jun 11, 2019

I just reverted it back to the most recent working state.
You're right, it should be using the same IMAGE_TAG as the other pipelines.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants