-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Conversation
…ry index i64, i128, float64
…ry index i256, sha256, ripemd160
… sha256, ripemd160
…ry index float128
…float128 to match the returned value (represented as uint128_t)
Any consideration on giving it a better name like |
|
plugins/chain_plugin/include/eosio/chain_plugin/chain_plugin.hpp
Outdated
Show resolved
Hide resolved
plugins/chain_plugin/include/eosio/chain_plugin/chain_plugin.hpp
Outdated
Show resolved
Hide resolved
plugins/chain_plugin/include/eosio/chain_plugin/chain_plugin.hpp
Outdated
Show resolved
Hide resolved
The |
@tbfleming Thanks for the feedback. I've updated my PR to fix the strict alias violation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also update the fc submodule to the latest master that will include the changes in EOSIO/fc#111.
@@ -51,7 +52,7 @@ struct permission { | |||
template<typename> | |||
struct resolver_factory; | |||
|
|||
// see specializations for uint64_t and double in source file | |||
// see specializations for uint64_t, uint128_t and double in source file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment can be reverted because there is no longer a need for a specialization for uint128_t
.
Docs team - I don't believe this change ever made it into our documentation. Can you please add it? |
Change Description
Related to #7313. This PR adds a new field called
more2
to the result of get_table_rows chain API. Themore2
field contains the key of the next row that wasn't returned in the response in the same format that was expected for thelower_bound
andupper_bound
fields of the request, i.e.This PR removes fixed_key.hpp as it's unused anymore and bring in fixed_bytes.hpp from eosio.cdt.
This PR also introduces breaking API changes for the input of get_table_rows for key-type sha256, ripemd160, i256. It also introduces breaking changes in the representation of uint128 in the JSON response (details below).
A new PR is also added in the FC repo EOSIO/fc#111
Consensus Changes
API Changes
This PR changes the input of get_table_rows for the following key-type:
And this PR changes the way uint128 being represented in the JSON response, from previously being represented as binary, it is now being represented as a decimal which is easier to be understood by the user.
Documentation Additions