This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
[develop] CMAKE version check before dependencies are installed #7553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arhag
reviewed
Jun 28, 2019
NorseGaud
changed the title
arhag
approved these changes
Jul 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Problem: People with versions less than the required don't see the requirement failure until too late (after dependencies are installed).
Solution: Add a check for the required version of CMAKE (using CMakeLists.txt) and compare it to the currently installed version.
Base Images pipeline tests & builds : https://buildkite.com/EOSIO/eosio-base-images/builds/339
Consensus Changes
API Changes
Documentation Additions