This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
[develop] Install location fix #7594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Problem: Several changes are not compatible with each other. EOSIO_INSTALL_DIR was not being set properly. Backing up the changes to the _BIN vars as they are loaded twice and won't get the INSTALL_LOCATION.
Also, I've moved the relative INSTALL_LOCATION fix into the install-directory-prompt function to make it easier to maintain.
Base Images: https://buildkite.com/EOSIO/eosio-base-images/builds/374
Consensus Changes
API Changes
Documentation Additions