This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
fix win32 build of eosio-blocklog #7640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.c_str() of a std/bfs::path returns a wchar array. On win32 use _wfopen() instead of fopen() so that we can handle these paths without down converting them to ASCII. I don't see any other way to do this if we want to keep the C file api. Also change the rename() calls to simply use the bfs::path variants for similar reasons. Also add "b" to open mode -- win32 does indeed have behavior differences there unlike POSIX.
johndebord
approved these changes
Jul 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on win32 .c_str() of a std/bfs::path returns a wchar array. Use _wfopen() instead of fopen() there so that we can handle these paths without down converting them to ASCII. I don't see any other way to do this if we want to keep the C file api.
Also change the rename() calls to simply use the bfs::path variants for similar reasons.
Also add "b" to open mode -- win32 does indeed have behavior differences there unlike POSIX.