Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

(chainbase sync) print name of DB causing failure condition & win32 fixes #7657

Merged
merged 2 commits into from
Jul 17, 2019

Conversation

spoonincode
Copy link
Contributor

Change Description

Gets EOSIO/chainbase#48 & EOSIO/chainbase#49

EOSIO/chainbase#49 (print name of DB causing failure condition) may be a 1.8 candidate

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

heifner
heifner previously approved these changes Jul 16, 2019
@heifner heifner dismissed their stale review July 16, 2019 21:32

Issue found

Copy link
Contributor

@heifner heifner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nodeos/main and eosio-blocklog/main both look for specify exception message "database dirty flag set"

@spoonincode
Copy link
Contributor Author

Though what's interesting is that for the nodeos case those can never be hit because the exception is swallowed up in appbase's init

@spoonincode spoonincode merged commit ed4ca81 into develop Jul 17, 2019
@spoonincode spoonincode deleted the chainbase_sync_20190716 branch July 17, 2019 02:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants