Fix memory leak #7672

heifner · 2019-07-22T22:48:23Z

Change Description

transaction_metadata::start_recover_keys captured a transaction_metadata shared_ptr of itself in a lambda to async_thread_pool. This capture created a cycle in reference counts of shared_ptr for the transaction_metadata causing a memory leak.
reset() the shared_ptr after use to prevent captured shared_ptr<transaction_metadata> from keeping the transaction_metadata alive.

…o prevent self reference

… to make lifetime clearer

heifner added 2 commits July 22, 2019 17:22

Capture copy of shared_ptr that can be reset in signing_keys_future t…

3fdbcb5

…o prevent self reference

Use weak_ptr for transaction_metadata instead of resetting shared_ptr…

0c874f0

… to make lifetime clearer

arhag approved these changes Jul 23, 2019

View reviewed changes

heifner merged commit e319cd9 into develop Jul 23, 2019

heifner deleted the fix-mem-leak branch July 23, 2019 11:57