This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Improve signature recovery #7721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d4aca74.
… processing incoming transaction after signature recovery
…ansaction interface
…a with recovered keys
heifner
commented
Aug 2, 2019
| } CATCH_AND_CALL(next); | ||
| } ); | ||
| } | ||
| }); | ||
| } |
There was a problem hiding this comment.
This is the key performance change. As odd as this looks, it is demonstratively better than before. And it is not the switch back to producer thread pool. Either thread pool (chain or producer) showed same results. The difference is in passing in a next std::function over calling future.wait().
swatanabe-b1
reviewed
Aug 2, 2019
| auto after_sig_recovery = | ||
| [self = this, trx, persist_until_expired, next{std::move(next)}]() mutable { | ||
| app().post(priority::low, [self, trx{std::move(trx)}, persist_until_expired, next{std::move(next)}]() { | ||
| self->process_incoming_transaction_async( trx, persist_until_expired, next ); |
There was a problem hiding this comment.
I don't know whether this matters, but next is being copied here.
There was a problem hiding this comment.
Yes it was. I tested a version where the lambda was mutable and it std::move but didn't make any difference.
arhag
suggested changes
Aug 6, 2019
…eated as needed in apply_block
This reverts commit 32b8208.
|
@arhag ready for review. |
arhag
suggested changes
Aug 12, 2019
…tributes private.
arhag
suggested changes
Aug 13, 2019
arhag
approved these changes
Aug 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
developbranch approach of passing anextfunction does not perform as well as just callingwait()on the future.packed_transactioninstead oftransaction_metadata.accept_transactionto take apacked_transactioninstead oftransaction_metadata.transaction_metadatais now constructed with the recovered public keys and signature cpu usage.transaction_metadatais now constructed withimplicitandscheduledconst values set.transaction_metadatais now immutable except for theacceptedflag.transaction_metadataconstruction is now restricted to static factory methodsstart_recover_keysandcreate_no_recover_keys.transaction_metadatainapply_blockif a previously applied block with cachedtransaction_metadata.Consensus Changes
API Changes
eosio::chain::plugin_interface::incoming::channels::transactionchanged fromtransaction_metadata_ptrtopacked_transaction_ptreosio::chain::plugin_interface::incoming::methods::transaction_asyncchanged fromvoid(const transaction_metadata_ptr&, bool, next_function<transaction_trace_ptr>), first_provider_policy>tovoid(const packed_transaction_ptr&, bool, next_function<transaction_trace_ptr>), first_provider_policy>Documentation Additions