This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Net plugin sync fix #7770
Merged
Net plugin sync fix #7770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjohnson5972
approved these changes
Aug 19, 2019
| @@ -957,7 +958,8 @@ namespace eosio { | |||
| self->sent_handshake_count = 0; | |||
| self->node_id = fc::sha256(); | |||
| my_impl->sync_master->sync_reset_lib_num( self->shared_from_this() ); | |||
| fc_dlog( logger, "closed, canceling wait on ${p}", ("p", self->peer_name()) ); // peer_name(), do not hold conn_mtx | |||
| fc_ilog( logger, "closing '${a}', ${p}", ("a", self->peer_address())("p", self->peer_name()) ); | |||
| fc_dlog( logger, "canceling wait on ${p}", ("p", self->peer_name()) ); // peer_name(), do not hold conn_mtx | |||
There was a problem hiding this comment.
Do we want the extra log statement just to make it clear, even though the same info is in the ilog statement?
There was a problem hiding this comment.
It has the additional info of peer_address() as requested by #7767
This was referenced Aug 19, 2019
This was referenced Sep 17, 2019
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
acceptor, close after thread pool is done.trx_in_progress_sizeon close, otherwise connection can never work again until restart. nodeos 1.7 and 1.8 get stuck at 100% CPU usage under heavy p2p load #7639Consensus Changes
API Changes
Documentation Additions