Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

[TRAVIS POC] Using platforms/dockerfiles/mac.sh as source of truth for generating Build, Parallel, Serial, and LRTs #7824

Merged
merged 127 commits into from
Aug 30, 2019

Conversation

NorseGaud
Copy link
Contributor

@NorseGaud NorseGaud commented Aug 28, 2019

Problem

Mac does not work inside of docker. We have to install dependencies on each run and that's painfully long. In order to interpolate the hash of the macos-10.14.sh script into the various steps, and avoid having to manually set them, I'd like to move to generating more than just serial tests programmatically. This allows us to obtain the hash once and then interpolate it in the various places we need it.

This also solves:

  1. Having to set IMAGE_TAG env in the pipeline.yml manually to the name of the dockerfile.
  2. Ensure step (with hashed tag name) can now be added easily using the same logic we use for other steps.
  3. Support for PINNED=false/UNPINNED=true being set and having to use the {platform}-unpinned tags (elimination of the unpinned.yml and code from the pipeline settings).
  4. Elimination of complicated docker hash function into a simpler helper.
  5. Elimination of generate-serial-tests.sh
  6. Long Running Tests are split out into "container level parallelization"

The pipeline has a generate step:

Screen Shot 2019-08-29 at 9 16 56 AM

After the generate step runs, it will show a complete pipeline:

Screen Shot 2019-08-29 at 9 17 52 AM

Tested

See Also

@kj4ezj kj4ezj mentioned this pull request Aug 30, 2019
3 tasks
@kj4ezj kj4ezj dismissed their stale review August 30, 2019 20:04

We merged in my commits from PR7831, so I am a contributor to this pull request now. Someone else will have to review.

Copy link
Contributor

@jerstern jerstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍪

@kj4ezj kj4ezj merged commit 8f33555 into trav-poc Aug 30, 2019
@kj4ezj kj4ezj deleted the trav-poc-code-gen branch August 30, 2019 20:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants