This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[TRAVIS POC] Using platforms/dockerfiles/mac.sh as source of truth for generating Build, Parallel, Serial, and LRTs #7824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kj4ezj
dismissed
their stale review
August 30, 2019 20:04
We merged in my commits from PR7831, so I am a contributor to this pull request now. Someone else will have to review.
jerstern
approved these changes
Aug 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍪
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Mac does not work inside of docker. We have to install dependencies on each run and that's painfully long. In order to interpolate the hash of the macos-10.14.sh script into the various steps, and avoid having to manually set them, I'd like to move to generating more than just serial tests programmatically. This allows us to obtain the hash once and then interpolate it in the various places we need it.
This also solves:
{platform}-unpinned
tags (elimination of the unpinned.yml and code from the pipeline settings).The pipeline has a generate step:
After the generate step runs, it will show a complete pipeline:
Tested
See Also