Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

[develop] Mac Builder Boost Fix #7873

Merged
merged 6 commits into from
Sep 9, 2019
Merged

[develop] Mac Builder Boost Fix #7873

merged 6 commits into from
Sep 9, 2019

Conversation

scottarnette
Copy link
Contributor

@scottarnette scottarnette commented Sep 9, 2019

Change Description

Added fixes for the following CICD issues:

  • Removed leftover SKIP_MOJAVE flag and replaced with flag used in build and test steps: SKIP_MACOS_10_14.
  • Fixed issue where Mac pinned builders were not source installing Boost 1.70.
    ** All pinned Mac builders now install Boost 1.70 from source.
    ** All unpinned Mac builders now install Boost via Brew.

See:
https://buildkite.com/EOSIO/eosio/builds/17140 | Pinned
https://buildkite.com/EOSIO/eosio-build-unpinned/builds/515 | Unpinned

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@spoonincode
Copy link
Contributor

CMake Warning at /usr/local/lib/cmake/boost_date_time-1.71.0/libboost_date_time-variant-static.cmake:59 (message):
--
  | Target Boost::date_time already has an imported location
  | '/usr/local/lib/libboost_date_time-mt.a', which will be overwritten with
  | '/usr/local/lib/libboost_date_time.a'

I get the impression the build directory may already exist with the contents of an old build when the build script is run?

@scottarnette
Copy link
Contributor Author

It's interesting because that output doesn't exist for the master or 1.8.x unpinned Mac builds, which use the same builder image since the dependencies are the same:
1.8.x | https://buildkite.com/EOSIO/eosio-build-unpinned/builds/516#288ef056-9721-470c-b159-c1b3e6624b8a/269-290
master | https://buildkite.com/EOSIO/eosio-build-unpinned/builds/512#d6b8fc97-a901-475a-adeb-105b9e8ec4f0/265-286

@scottarnette
Copy link
Contributor Author

scottarnette commented Sep 9, 2019

Manual inspection of the Mac builder image showed that no eos directory exists prior to the clone performed by Buildkite.

@arhag arhag merged commit 76dcd5c into develop Sep 9, 2019
@arhag arhag deleted the cicd-mac-boost-dev branch September 9, 2019 18:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants