Create Release Build Test

[kj4ezj]

Change Description

We have no good way of knowing whether a binary was built with compiler optimizations enabled or not. To address this, I created an integration test which fails when the debug flag is set in nodeos.

While the debug flag does not necessarily indicate whether compiler optimizations were used, this flag does correlate for common build types (debug, release, etc).

Notes

• This variant of the test calls nodeos --extract-build-info, then checks the JSON file it creates to determine if the debug byte is set or not.
  • This is different from how the same test on eos:develop works.
• Though I can write the test to only fail in a CI environment like Buildkite, it currently fails for local debugging builds as well. I know a lot of members of our community build and install EOSIO for production systems from source, and I wanted this test to be able to catch build-type errors for those users despite any inconvenience to our own developers. This test behavior is open to persuasion from any stakeholders.
• The test provides useful error messages when test prerequisites are not met, and when the test fails.
• Base-Image changes:
  • The vim-common package is now installed because it includes xxd, which is required for hex dumps.
    • Though this is not required for this variant of this test (it is required for the other variant), it is useful to have in the base-images for manual debugging or for future tests.
  • The jq package is now installed (from epel-release on CentOS) to parse JSON output from nodeos.
• This test is not being added to release/1.7.x because there is no easy, programmatic way to check for debug symbols prior to release/1.8.x.

See Also

• Pull request 7864 -- add --print-build-info and --extract-build-info flags to nodeos on eos:develop
• Pull request 7877 -- create release-build-test on eos:develop
• Pull request 7882 -- create release-build-test on eos:release/1.8.x

Consensus Changes

• Consensus Changes
  None.

API Changes

• API Changes
  None.

Documentation Additions

• Documentation Additions
  None.

[heifner]

This information is available via the new --extract-build-info #7864

{
  "debug": false,
  "os": "OS_LINUX",
  "arch": "ARCH_X86_64",
  "boost_version": 107000,
  "compiler": "4.2.1 Compatible Clang 7.0.0 (tags/RELEASE_700/final)"
}

[spoonincode]

fwiw -frecord-gcc-switches works really well in clang (not so much gcc). If you really wanted to check it was really made with optimization turned on and/or track other flags.

[kj4ezj]

fwiw -frecord-gcc-switches works really well in clang (not so much gcc). If you really wanted to check it was really made with optimization turned on and/or track other flags.

After discussing this test with the others, we have decided we want several of these build environment tests. I will add this check to my notes.