Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix exit crash - develop #7891

Merged
merged 1 commit into from
Sep 11, 2019
Merged

Fix exit crash - develop #7891

merged 1 commit into from
Sep 11, 2019

Conversation

heifner
Copy link
Contributor

@heifner heifner commented Sep 11, 2019

Change Description

  • nodeos has been core dumping on exit intermittently for our 1.8.x nodeos_startup_catchup_lr_test
  • core file indicated processing of publish of transaction result during destruction of io_context
  • Add application post of low priority item to application queue with capture of shared_ptr of impls of producer_plugin_impl to keep it alive. The net_plugin already had this shutdown behavior.
  • 40+ runs of nodeos_startup_catchup_lr_test of 1.8.x all passed with this fix.
  • Ported this from 1.8.x to develop even though develop tests were not failing since it seems like it could at least in theory be an issue on develop branch.

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@heifner heifner merged commit bbba89e into develop Sep 11, 2019
@heifner heifner deleted the fix-exit-crash-dev branch September 11, 2019 23:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants