This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
nodeos
has been core dumping on exit intermittently for our 1.8.xnodeos_startup_catchup_lr_test
publish
of transaction result during destruction ofio_context
shared_ptr
of impls ofproducer_plugin_impl
to keep it alive. Thenet_plugin
already had this shutdown behavior.nodeos_startup_catchup_lr_test
of 1.8.x all passed with this fix.develop
tests were not failing since it seems like it could at least in theory be an issue ondevelop
branch.Consensus Changes
API Changes
Documentation Additions