This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
decouple wavm runtime from being required & initial support for platform specific wasm runtimes #7919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swatanabe-b1
approved these changes
Sep 16, 2019
| #define _ADD_PAREN_1_END | ||
| #define _ADD_PAREN_2_END | ||
| #define _WRAPPED_SEQ(SEQ) BOOST_PP_CAT(_ADD_PAREN_1 SEQ, _END) | ||
|
|
There was a problem hiding this comment.
These are reserved identifiers.
There was a problem hiding this comment.
not sure if @b1bart has any thoughts on why there are named that way
There was a problem hiding this comment.
bad habit I suppose. feel free to rename them and properly undefine them it is merely a nod to the idea that they are "internal".
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
eosio's code currently assumes that both wabt and wavm wasm runtimes will be built and available. This hasn't been much of a problem except for interfering with unsupported win32 builds where our wavm fork is non functional.
Looking forward to 2.0 though, there will be more diversity in what platforms different runtimes support. It's currently looking like:
This PR adds some initial basic scaffolding to support central definition of what runtimes are supported. Frankly I don't care much for this approach as it just dumps some
#ifdefsaround which I'd rather not do. However there are aspects that make something cleaner more challenging: the way we've constructed the intrinsic registration, that we need parts of the wavm intrinsics even when not using wavm (because we use the wavm "linker" for validation), and some runtimes like EOS-VM OC have additional runtime options.There is a functional issue where if you
unittests/unit_test -- --unsupported-runtimeall the tests simply fail instead of unit_test stopping early. Butctestis properly set up only register runtimes that are enabled.If anyone wants to take a go at a better approach before 2.0, no beef here.
As part of the above effort, this PR also makes wavm's runtime enabled only on non-win32 builds. You can experiment with this on any platform by manually changing the
if()in the cmakelists, and see that wavm is not allowed as a runtime nor does it show up inctestConsensus Changes
API Changes
Documentation Additions