This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
return error when attempting to remove key from YubiHSM wallet #7923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The YubiHSM keosd wallet doesn't support removing keys from the YubiHSM. This is mostly because the interaction with the YubiHSM for removing a key is tricky given our desire to validate the wallet password before performing that action. Implementing this would mean opening up a second simultaneous session with the YubiHSM just to verify the wallet password. While this may be a valid enhancement in the future, it's too much effort for now. That said, the current implementation was silently dropping removal requests. Fix it to return an error so it's not deceptive.
jeffreyssmith2nd
approved these changes
Sep 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
The YubiHSM keosd wallet doesn't support removing keys from the YubiHSM. This is mostly because the interaction with the YubiHSM for removing a key is tricky given our desire to validate the wallet password before performing that action. Implementing this would mean opening up a second simultaneous session with the YubiHSM just to verify the wallet password. While this may be a valid enhancement in the future, it's too much effort for now.
That said, the current implementation was silently dropping removal requests. Fix it to return an error so it's not deceptive.
Fixes #7904
Consensus Changes
API Changes
Documentation Additions