Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

[Develop] Support all BK/Travis cases in Submodule Regression Script #7933

Merged
merged 8 commits into from
Sep 17, 2019

Conversation

NorseGaud
Copy link
Contributor

@NorseGaud NorseGaud commented Sep 16, 2019

Problems:

  1. When manually running a forked PR using pull/7924/head:develop-submodule-regression-fix, the script will fail to use the merged commit for that forked PR.
  2. git log logic wasn't working and throwing exit 1

Solutions:

  1. Support if the PR slug exists (it's a forked PR) by doing git fetch/checkout of the ghost/merged commit.
  2. Added no-pager and changed the logic to wrap in test

Travis

Buildkite

@NorseGaud
Copy link
Contributor Author

1.8.x: #7936
1.7.x: #7938

.cicd/submodule-regression-check.sh Outdated Show resolved Hide resolved
.cicd/submodule-regression-check.sh Outdated Show resolved Hide resolved
.cicd/submodule-regression-check.sh Outdated Show resolved Hide resolved
@NorseGaud
Copy link
Contributor Author

Submodule running in travis (with if at end) works: https://travis-ci.com/EOSIO/eos/jobs/236503103

@NorseGaud NorseGaud merged commit 2926d0b into develop Sep 17, 2019
@NorseGaud NorseGaud deleted the develop-submodule-regression-script-fix branch September 17, 2019 19:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants