This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
set immutable chain_id during construction of controller #7962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… introduced in #7841 in which plugins like net_plugin were incorrectly using the default chain ID
heifner
suggested changes
Sep 21, 2019
heifner
approved these changes
Sep 21, 2019
This was referenced Sep 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Fixes a bug introduced in #7841 in which plugins like net_plugin were incorrectly using the default chain ID.
Consensus Changes
API Changes
Documentation Additions