This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
port consolidated security fixes for 1.8.4 to develop; add unit tests associated with consolidated security fixes for 1.8.1 #7983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- WebAssembly checktime fixes Co-Authored-By: Matt Witherspoon <32485495+spoonincode@users.noreply.github.com>
… produced block numbers in block_header_state
heifner
approved these changes
Sep 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Port consolidated security fixes for 1.8.4 to develop
Consolidated Security Fixes ported from 1.8.4 to develop
Co-Authored-By: Matt Witherspoon 32485495+spoonincode@users.noreply.github.com
Add unit tests associated with consolidated security fixes for 1.8.1
The consolidated security fixes for 1.8.1 (#7619) fixed a consensus protocol regression bug introduced in v1.8.0-rc1 (transitioning from v1.7.x to v1.8.1 avoids this unintended consensus change). The
producer_to_last_producedmap withinblock_header_statewas incorrectly setting a block number within the map that was one less than the intended block number during the normal case when a pending schedule was not promoted to active.This PR now brings in an augmentation to an existing unit test to check for the expected values in the
producer_to_last_producedmap.Consensus Changes
API Changes
Documentation Additions