This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Add nodeos/cleos/keosd docs from develop, update README #8293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lparisc
added
the
documentation
Requires attention from documentation team. e.g. documentation is expected to be generated.
label
Dec 23, 2019
arhag
suggested changes
Jan 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have only reviewed docs/00_install/
files and README.md
. I will not be reviewing the other sections thoroughly since they should have already been reviewed by others. But if you want me to quickly look into a very specific part of the other sections, let me know.
By the way, the requested changes will also apply to the develop version of this PR.
docs/00_install/01_build-from-source/02_manual-build/03_platforms/ubuntu-18.04-unpinned.md
Show resolved
Hide resolved
docs/00_install/01_build-from-source/02_manual-build/03_platforms/ubuntu-18.04-unpinned.md
Show resolved
Hide resolved
docs/00_install/01_build-from-source/02_manual-build/03_platforms/ubuntu-18.04-unpinned.md
Show resolved
Hide resolved
arhag
approved these changes
Jan 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
documentation
Requires attention from documentation team. e.g. documentation is expected to be generated.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Consensus Changes
API Changes
Documentation Additions