This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
reset the new handler #8307
Merged
reset the new handler #8307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Want to see if the tests fail with the handler unset and ensure that the tests pass when I uncomment the |
heifner
suggested changes
Dec 11, 2019
libraries/chain/controller.cpp
Outdated
| @@ -304,6 +315,8 @@ struct controller_impl { | |||
| read_mode( cfg.read_mode ), | |||
| thread_pool( "chain", cfg.thread_pool_size ) | |||
| { | |||
|
|
|||
| // reset the | |||
There was a problem hiding this comment.
Looks like this was added unintentionally and also the newline below.
heifner
approved these changes
Dec 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Because LLVM sets the new_handler to abort when new cannot allocate any more memory, we've lost the ability to exit cleanly in some instances and not corrupt the DB. This fix should reset the new_handler to throw
std::bad_allocand use the old behavior of EOSIO.Consensus Changes
API Changes
Documentation Additions