Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix bios boot python script due to 2.0.x changes #8328

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Fix bios boot python script due to 2.0.x changes #8328

merged 1 commit into from
Jan 9, 2020

Conversation

iamveritas
Copy link
Contributor

@iamveritas iamveritas commented Dec 14, 2019 •
edited
Loading

Change Description

Script was modified to:

  1. Activate PREACTIVATE_FEATURE first
  2. Deploy eosio.system version 1.8.0
  3. Add all protocol features, including those introduced by 2.0.x
  4. Deploy eosio.system version 1.9.0

Updated README.md file with steps to build the eosio.contracts older version as well.

Resolves #8261

  • Documentation Updates

@iamveritas iamveritas added the documentation Requires attention from documentation team. e.g. documentation is expected to be generated. label Dec 14, 2019
@iamveritas iamveritas self-assigned this Dec 14, 2019
Update REAMDE.md and python script
45b12bd 
correct the path to latest eosio.system contract

changes which make the script do more for the user; the point is user is in 2.0.x so the script should in the end launch a 2.0.x, that includes the 1.9.x (latest) eosio.system contracts not an older one.

small corrections on readme file.
@heifner
Copy link
Contributor

heifner commented Dec 17, 2019

I assume this is no longer draft.

@iamveritas iamveritas marked this pull request as ready for review December 18, 2019 07:56
@iamveritas
Copy link
Contributor Author

I assume this is no longer draft.

so vigilentè, me like it!

@heifner heifner mentioned this pull request Jan 3, 2020
Closed
@dskvr
Copy link
Contributor

dskvr commented Jan 8, 2020

@b1bart Can you weigh in on the subject?

arhag
arhag approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@arhag arhag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave the debate over committing old contracts alone for now. Eventually we will be able to avoid that whole mess anyway by introducing the eosio.boot contract in a future release of eosio.contracts.

@arhag arhag merged commit f205c84 into release/2.0.x Jan 9, 2020
@arhag arhag deleted the docs/2.0.x-bios-boot-tutorial branch January 9, 2020 22:51
@iamveritas iamveritas mentioned this pull request Jan 10, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arhag arhag arhag approved these changes

@dskvr dskvr Awaiting requested review from dskvr

@lparisc lparisc Awaiting requested review from lparisc

@heifner heifner Awaiting requested review from heifner

Assignees

@iamveritas iamveritas

Labels
documentation Requires attention from documentation team. e.g. documentation is expected to be generated.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iamveritas @heifner @dskvr @arhag