Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Default to returning WASM as returning WAST has been deprecated. #9706

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Default to returning WASM as returning WAST has been deprecated. #9706

merged 1 commit into from
Dec 7, 2020

Conversation

deckb
Copy link
Contributor

@deckb deckb commented Nov 23, 2020

Change Description

As there is no more support for get_code to return WAST the default to return WASM should be true.

Change Type

Select ONE

  • Documentation
  • Stability bug fix
  • [ X] Other
  • Other - special case

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@deckb deckb requested a review from b1bart November 23, 2020 14:48
b1bart
b1bart approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@b1bart b1bart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing as though the OpenAPI docs for this endpoint was already suggesting this defaults to true it would be nice if it did 👍

@heifner heifner merged commit edb1833 into EOSIO:develop Dec 7, 2020
@heifner heifner mentioned this pull request May 14, 2022
Closed
@oschwaldp-oci oschwaldp-oci mentioned this pull request May 18, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@b1bart b1bart b1bart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deckb @b1bart @heifner