This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Return failure traces when running with amqp_trx_plugin #9872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swatanabe-b1
suggested changes
Jan 4, 2021
| @@ -491,7 +491,8 @@ class producer_plugin_impl : public std::enable_shared_from_this<producer_plugin | |||
| bool process_incoming_transaction_async(const transaction_metadata_ptr& trx, | |||
| bool persist_until_expired, | |||
| next_function<transaction_trace_ptr> next, | |||
| RetryLaterFunc retry_later) | |||
| RetryLaterFunc retry_later, | |||
| bool return_failure_trace = false) | |||
There was a problem hiding this comment.
This seems pretty fragile to me. I think you'd be better of making sure that all downstream consumers can handle a transaction trace with an exception appropriately, and never extract the exception here. Either that or somehow use types that enforce consistency between return_failure_trace and next.
There was a problem hiding this comment.
For now this will only be true for amqp_trx_plugin. However, a new send_transaction2 in the future should also work this way (at least optionally). The community has requested this type of behavior.
…action_trace failures
swatanabe-b1
approved these changes
Jan 4, 2021
swatanabe-b1
reviewed
Jan 4, 2021
swatanabe-b1
approved these changes
Jan 5, 2021
This was referenced Sep 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
amqp_trx_pluginChange Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions
Documentation Additions
When running with amqp_trx_plugin,
transaciton_tracecan be returned for partial executed transactions which includes the exception. It is up to the user to understand these traces as failure cases.