Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

DeepMind logger holds const char* fields that it uses for some of its naming and indicators #9877

Merged
merged 2 commits into from
Jan 6, 2021
Merged

DeepMind logger holds const char* fields that it uses for some of its naming and indicators #9877

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e15aab6
Change char* data members to std::string data members.
Jan 5, 2021
7b3cfa0
Remove usage of std::move
Jan 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions libraries/chain/include/eosio/chain/trace.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,19 +86,19 @@ namespace eosio { namespace chain {

struct storage_usage_trace {
public:
storage_usage_trace(uint32_t action_id, std::string event_id, const char* family, const char* operation)
:storage_usage_trace(action_id, std::move(event_id), family, operation, ".")
storage_usage_trace(uint32_t action_id, std::string event_id, std::string_view family, std::string_view operation)
:storage_usage_trace(action_id, std::move(event_id), std::move(family), std::move(operation), ".")
heifner marked this conversation as resolved.
Show resolved Hide resolved
{}

storage_usage_trace(uint32_t action_id, std::string&& event_id, const char* family, const char* operation, const char* legacy_tag)
storage_usage_trace(uint32_t action_id, std::string&& event_id, std::string_view family, std::string_view operation, std::string_view legacy_tag)
:action_id(action_id),event_id(std::move(event_id)),family(family),operation(operation),legacy_tag(legacy_tag)
{}

uint32_t action_id = 0;
const std::string event_id = "generic";
const char* family = "generic";
const char* operation = "generic";
const char* legacy_tag = "generic";
const std::string family = "generic";
const std::string operation = "generic";
const std::string legacy_tag = "generic";

private:
storage_usage_trace(uint32_t action_id)
Expand Down