This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Explicit ABI conversion of signed_transaction #9960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncy in abi_serializer code)
…action_generation exception
larryk85
approved these changes
Jan 29, 2021
|
|
||
| // can have "deferred_transaction_generation" (if there is a deferred transaction and the extension was "extracted" to show data), | ||
| // or "transaction_extensions" (either as empty or containing the packed deferred transaction), | ||
| // or both (when there is a deferred transaction and extension was "extracted" to show data and a redundant "transacation_extensions" was provided), |
There was a problem hiding this comment.
misspelling of transaction after redundant.
… require fields be present.
larryk85
approved these changes
Feb 1, 2021
heifner
suggested changes
Feb 2, 2021
…c_reflect definitions.
heifner
approved these changes
Feb 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
EPE-72
Explicit ABI conversion of signed_transaction to work around deficiencies of abi_serializer code for inherited transaction_extensions.
Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions