This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fix Docker RMI Failure #1113
Merged
Fix Docker RMI Failure #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
From #help-automation, eosio-dot-cdt build 3461, and AUTO-876 in epic AUTO-880, tagged builds are failing because the
docker rmicommand is not followed by an "or no-op"|| :to suppress the error if the image no longer exists.This is an error we have already solved in EOSIO. In fact, quite a bit of work has gone into the equivalent script in EOSIO, so I just went ahead and copied it here (with the relevant name changes) from commit a7b5566.
I also brought in the branch name sanitation code I wrote for AUTO-848. The set of characters allowed in
gitbranch names is much larger than the set of characters allowed in docker container names, so this code removes or replaces those characters following a specific and predictable pattern.See Also
developrelease/1.8.xrelease/1.7.xAPI Changes
None.
Documentation Additions
None.