Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

[docs] kv api example contract #961

Merged
merged 10 commits into from
Sep 1, 2020
Merged

[docs] kv api example contract #961

merged 10 commits into from
Sep 1, 2020

Conversation

iamveritas
Copy link
Contributor

@iamveritas iamveritas commented Aug 28, 2020

adding kv api example contract

@iamveritas iamveritas added the documentation Documentation related edits, non-breaking only label Aug 28, 2020
@iamveritas iamveritas self-assigned this Aug 28, 2020
@iamveritas iamveritas changed the title docs/kv apis abi [docs] kv api example contract Aug 28, 2020
@iamveritas iamveritas marked this pull request as ready for review August 28, 2020 11:04
@halsaphi
Copy link
Contributor

halsaphi commented Sep 1, 2020

A comment to explain the magic numbers in the getters would be useful:

i.e.

string get_last_name() const {
return get<1>(this->last_name);
}

@halsaphi
Copy link
Contributor

halsaphi commented Sep 1, 2020

  • comment on 'using' and 'action_wrapper' - explain why you use aliasing and the benefit of action_wrapper.

  • is it possible to highlight differences in using kv api vs db api?

@iamveritas
Copy link
Contributor Author

  • comment on 'using' and 'action_wrapper' - explain why you use aliasing and the benefit of action_wrapper.
  • is it possible to highlight differences in using kv api vs db api?

these are good thoughts but they are out of scope of this code example
for first one we have documentation to cover it, if user doesn't know what an action wrapper is s/he will look it up and find it.
for second it will be explained in the explainer page

@iamveritas iamveritas merged commit f52bf18 into develop Sep 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation related edits, non-breaking only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants