This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
We have noticed several PRs from forked repositories are failing in Travis. This was determined to be caused by Travis builds being unable to determine the dependent eosio and eosio.cdt versions via the Github API.
Fixed CI issues regarding forked PRs:
pipeline.jsonc
.eosio.cdt
repository and checkouts the defined dependency (branch or commit hash). Then,git rev-parse --verify HEAD
is executed to determine the HEAD commit hash, just incase the dependency is referenced by branch. I am open to other suggestions for determining the CDT binary to install.See:
https://travis-ci.com/EOSIO/eosio.contracts/builds/135300601 | Travis build non-forked.
https://travis-ci.com/EOSIO/eosio.contracts/builds/135301926 | Travis build from forked PR.
https://buildkite.com/EOSIO/eosio-dot-contracts/builds/784 | Unaffected Buildkite build.
Deployment Changes
API Changes
Documentation Additions